Switching playcount increment time

[Jeff Mitchell]

On 03/16/2010 10:49 PM, Leo Franchi wrote:
> On Tue, Mar 16, 2010 at 7:00 PM, Nanno Langstraat <langstr at gmail.com> wrote:
>> Jeff Mitchell wrote:
>>> I can't speak for anybody else, but having just looked through that
>>> patch I have no plans to merge it as-is. [...]
>>>
>>> It's also generally best practice to actually indicate what bugs you are
>>> fixing rather than say that it's a collection of bug fixes and leave it
>>> to other people to try to figure out what the problem is in the first place.
>>>
>>
>> Beg pardon?
>>
>> When you click "Select commits" in Gitorious you'll see a perfectly nice
>> list of commit messages.
>>
>> On top of that, I even added a comment to the Merge Request later when I
>> happened to notice a BUG report that matches one of my bugfixes.
>>
>> What more do you expect?
> 
> I've gotta say, i'm with Nanno on this one. The individual commits are
> really clear on what they do.

I wasn't aware of the "Select commits" link (is it new in the last 6 or
9 months?). My past experience has been that relevant information is in
the merge request itself and that you look at the various diffs in the MR.

Whatever, that wasn't my problem with the merge request in the first
place, so getting all huffy about that is a bit of a sidetrack.

--Jeff

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 262 bytes
Desc: OpenPGP digital signature
Url : http://mail.kde.org/pipermail/amarok-devel/attachments/20100317/f1ebed7d/attachment.sig