Switching playcount increment time

Leo Franchi lfranchi at kde.org
Wed Mar 17 03:49:25 CET 2010


On Tue, Mar 16, 2010 at 7:00 PM, Nanno Langstraat <langstr at gmail.com> wrote:
> Jeff Mitchell wrote:
>> I can't speak for anybody else, but having just looked through that
>> patch I have no plans to merge it as-is. [...]
>>
>> It's also generally best practice to actually indicate what bugs you are
>> fixing rather than say that it's a collection of bug fixes and leave it
>> to other people to try to figure out what the problem is in the first place.
>>
>
> Beg pardon?
>
> When you click "Select commits" in Gitorious you'll see a perfectly nice
> list of commit messages.
>
> On top of that, I even added a comment to the Merge Request later when I
> happened to notice a BUG report that matches one of my bugfixes.
>
> What more do you expect?

I've gotta say, i'm with Nanno on this one. The individual commits are
really clear on what they do.

or at least, they would be clear if I knew how the playlist code worked :)

leo


-- 
_____________________________________________________________________
leonardo.franchi at tufts.edu         Tufts  University 2010
leo at kdab.com                                 KDAB (USA), LLC
lfranchi at kde.org                             The KDE Project


More information about the Amarok-devel mailing list