RandomTrackNavigator
Nanno Langstraat
langstr at gmail.com
Wed Mar 10 05:04:51 CET 2010
Thomas Lübking wrote:
> Ok, attached is a patch*.
>
I took a somewhat different approach; see attachment.
Probably won't compile, but good enough for inspection.
Points:
* Either patch is definitely not for v2.3.
* Similar amount of code overall.
* Fixes BUG 229226 / 222129 properly, getting rid of the awful hack.
(the related bookkeeping causes the bulk of new code)
* Decision-making code is IMHO a little easier to verify & maintain.
* Does not assume that 'likelyNextTrack()' will never be called
before 'activeTrackChanged()'.
* Does not call 'reset()' from 'likelyNextTrack()'.
* New feature: history doesn't suddenly disappear at wrap-around.
* New minor feature: when the user clicks on an unplayed item, we
leave "replayed" mode.
Regards,
Nanno
-------------- next part --------------
A non-text attachment was scrubbed...
Name: RandomTrackNavigator.cpp
Type: text/x-c++src
Size: 8425 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/amarok-devel/attachments/20100310/257e433f/attachment-0001.cpp
-------------- next part --------------
A non-text attachment was scrubbed...
Name: RandomTrackNavigator.h
Type: text/x-chdr
Size: 4136 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/amarok-devel/attachments/20100310/257e433f/attachment-0001.h
More information about the Amarok-devel
mailing list