RandomTrackNavigator (was: ready for tagging?)

[Thomas Lübking]

Ok, attached is a patch*.

As far as i can say it fixes everything (except that playlist filtering is not 
handled by the toolbar labels, but that needs to be fixed there)

The only problem is:
it's quite massive =)

==> should i make a merge request despite the late date?

(i'll be away in a couple of minutes and not available until tomorrow 
"afternoon" CET - if you want it in faster, feel free to merge the patch 
yourself anyone)

Cheers,
Thomas

All list manipulation logic is moved into the changeActiveTrack slot** (I also 
renamed the slots being at it anyway... :)
likleyNext/LastTrack just look up the lists in the right order and 
next/lastTrack simply call their sneak variants.

**the interference between slot and next/prev turned out to be the core 
troublemakers, also responsible for the diminished deterministic behaviour of 
the very original navigator (iirc it skipped a track every now and then) - 
when this degree of precision was probably just not required :)


Am Monday 08 March 2010 schrieb Nanno Langstraat:
> Hi,
> 
> Sorry that I can't reply directly to the "ready for tagging?" thread.
> I've just subscribed to the list.
> 
> I was already planning / resigned to cleaning that mess in
> RandomTrackNavigator, due to FilterProxy.
> 
> But IMHO it seems too much while in a code freeze.
> 
> 
> Hints of what I want to do:
> 
>     * Separate the history bookkeeping (for requestLast) from the "don't
>       play a track twice in 1 run" bookkeeping.
> 
>     * Choose only 1 playlist item ahead of time.
> 
>     * Get rid of duplicate decision code introduced by MR 106.
> 
>       (NEVER EVER copy&paste decision code that's >= 3 lines !)
>       (It seems unfortunate interplay between Thomas and Ian Monroe led
>       to that)
> 
>     * Use signal 'rowsInserted' etc. instead of 'insertedIds' etc.
> 
> 
> 
>     Cheers,
>     Nanno
> 
> _______________________________________________
> Amarok-devel mailing list
> Amarok-devel at kde.org
> https://mail.kde.org/mailman/listinfo/amarok-devel

-------------- next part --------------
A non-text attachment was scrubbed...
Name: randomtracknavigator.diff
Type: text/x-patch
Size: 11393 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/amarok-devel/attachments/20100309/2fe0d5dc/attachment.diff