Review Request: File tag handler refactoring

[Stefan Derkits]

> On 2010-12-13 12:13:59, Ralf Engels wrote:
> > Looks nice,
> > can we delay the integration until Amarok 2.4 is out?
> 
> Stefan Derkits wrote:
>     The additional Filetypes in Filetype.h and Filetype.cpp could be cool if they are already in 2.4, cause in 2.4 the Display of the Filetypes is taken from the Database (and also the Type that it puts in the Database).
>     So every Filetype that was previously not known (everything except Mp3,Ogg,Wma,Mp4) would be displayed as Other in the Properties of the File and woud get a Database Value of 0.
> 
> Sergey Ivanov wrote:
>     Yeah, sure It can wait as long as we need. It's not hard to keep It updated, since patch doesn't modify legacy files a lot.
>     
>     Stefan, It's not critical since all this zeros will get fixed during first collection scanner run after commit.

Yeah but for Users who don't use GIT it's fixed in 2.4.1 or 2.5 .. till then they see "Unknown" for all previously not known Files
But as this is a small Issue, it could wait. On the other Hand, the Changes on Filetype.h & Filetype.cpp are pretty small ...


- Stefan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100191/#review517
-----------------------------------------------------------


On 2010-12-11 11:52:39, Sergey Ivanov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100191/
> -----------------------------------------------------------
> 
> (Updated 2010-12-11 11:52:39)
> 
> 
> Review request for Amarok.
> 
> 
> Summary
> -------
> 
> Rewrite tag reading stuff to make It more OOP way. Add separat classes for each Tag format (ID3v2, APE, ASF, VorbisComment, MP4, MPC). Exclude almost all "magic words" (frame/field names) from code.
> TODO:
> Implement charset detection stuff.
> 
> 
> Diffs
> -----
> 
>   shared/FileType.h dc5e57b 
>   shared/FileType.cpp 63d81c7 
>   shared/MetaTagLib.h ff27c92 
>   shared/MetaTagLib.cpp 3f7e758 
>   shared/TagsFromFileNameGuesser.h PRE-CREATION 
>   shared/TagsFromFileNameGuesser.cpp PRE-CREATION 
>   shared/tag_helpers/APETagHelper.h PRE-CREATION 
>   shared/tag_helpers/APETagHelper.cpp PRE-CREATION 
>   shared/tag_helpers/ASFTagHelper.h PRE-CREATION 
>   shared/tag_helpers/ASFTagHelper.cpp PRE-CREATION 
>   shared/tag_helpers/ID3v2TagHelper.h PRE-CREATION 
>   shared/tag_helpers/ID3v2TagHelper.cpp PRE-CREATION 
>   shared/tag_helpers/MP4TagHelper.h PRE-CREATION 
>   shared/tag_helpers/MP4TagHelper.cpp PRE-CREATION 
>   shared/tag_helpers/StringHelper.h PRE-CREATION 
>   shared/tag_helpers/StringHelper.cpp PRE-CREATION 
>   shared/tag_helpers/TagHelper.h PRE-CREATION 
>   shared/tag_helpers/TagHelper.cpp PRE-CREATION 
>   shared/tag_helpers/VorbisCommentTagHelper.h PRE-CREATION 
>   shared/tag_helpers/VorbisCommentTagHelper.cpp PRE-CREATION 
>   src/CMakeLists.txt a23bbdb 
>   src/core-impl/meta/file/File_p.h 9f1df54 
>   src/musicbrainz/MusicBrainzFinder.cpp 78a07a6 
>   utilities/collectionscanner/CMakeLists.txt 6be9319 
> 
> Diff: http://git.reviewboard.kde.org/r/100191/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sergey
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/amarok-devel/attachments/20101214/9624639f/attachment.htm