Review Request: File tag handler refactoring

[Stefan Derkits]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100191/#review555
-----------------------------------------------------------



shared/FileType.h
<http://git.reviewboard.kde.org/r/100191/#comment423>

    RealAudio is missing ... maybe some other Types


- Stefan


On 2010-12-11 11:52:39, Sergey Ivanov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100191/
> -----------------------------------------------------------
> 
> (Updated 2010-12-11 11:52:39)
> 
> 
> Review request for Amarok.
> 
> 
> Summary
> -------
> 
> Rewrite tag reading stuff to make It more OOP way. Add separat classes for each Tag format (ID3v2, APE, ASF, VorbisComment, MP4, MPC). Exclude almost all "magic words" (frame/field names) from code.
> TODO:
> Implement charset detection stuff.
> 
> 
> Diffs
> -----
> 
>   shared/FileType.h dc5e57b 
>   shared/FileType.cpp 63d81c7 
>   shared/MetaTagLib.h ff27c92 
>   shared/MetaTagLib.cpp 3f7e758 
>   shared/TagsFromFileNameGuesser.h PRE-CREATION 
>   shared/TagsFromFileNameGuesser.cpp PRE-CREATION 
>   shared/tag_helpers/APETagHelper.h PRE-CREATION 
>   shared/tag_helpers/APETagHelper.cpp PRE-CREATION 
>   shared/tag_helpers/ASFTagHelper.h PRE-CREATION 
>   shared/tag_helpers/ASFTagHelper.cpp PRE-CREATION 
>   shared/tag_helpers/ID3v2TagHelper.h PRE-CREATION 
>   shared/tag_helpers/ID3v2TagHelper.cpp PRE-CREATION 
>   shared/tag_helpers/MP4TagHelper.h PRE-CREATION 
>   shared/tag_helpers/MP4TagHelper.cpp PRE-CREATION 
>   shared/tag_helpers/StringHelper.h PRE-CREATION 
>   shared/tag_helpers/StringHelper.cpp PRE-CREATION 
>   shared/tag_helpers/TagHelper.h PRE-CREATION 
>   shared/tag_helpers/TagHelper.cpp PRE-CREATION 
>   shared/tag_helpers/VorbisCommentTagHelper.h PRE-CREATION 
>   shared/tag_helpers/VorbisCommentTagHelper.cpp PRE-CREATION 
>   src/CMakeLists.txt a23bbdb 
>   src/core-impl/meta/file/File_p.h 9f1df54 
>   src/musicbrainz/MusicBrainzFinder.cpp 78a07a6 
>   utilities/collectionscanner/CMakeLists.txt 6be9319 
> 
> Diff: http://git.reviewboard.kde.org/r/100191/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sergey
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/amarok-devel/attachments/20101214/e6f8ef9c/attachment-0001.htm