<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/100191/">http://git.reviewboard.kde.org/r/100191/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On December 13th, 2010, 12:13 p.m., <b>Ralf Engels</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Looks nice,
can we delay the integration until Amarok 2.4 is out?</pre>
</blockquote>
<p>On December 13th, 2010, 12:38 p.m., <b>Stefan Derkits</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The additional Filetypes in Filetype.h and Filetype.cpp could be cool if they are already in 2.4, cause in 2.4 the Display of the Filetypes is taken from the Database (and also the Type that it puts in the Database).
So every Filetype that was previously not known (everything except Mp3,Ogg,Wma,Mp4) would be displayed as Other in the Properties of the File and woud get a Database Value of 0.</pre>
</blockquote>
<p>On December 14th, 2010, 2:07 p.m., <b>Sergey Ivanov</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Yeah, sure It can wait as long as we need. It's not hard to keep It updated, since patch doesn't modify legacy files a lot.
Stefan, It's not critical since all this zeros will get fixed during first collection scanner run after commit.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Yeah but for Users who don't use GIT it's fixed in 2.4.1 or 2.5 .. till then they see "Unknown" for all previously not known Files
But as this is a small Issue, it could wait. On the other Hand, the Changes on Filetype.h & Filetype.cpp are pretty small ...</pre>
<br />
<p>- Stefan</p>
<br />
<p>On December 11th, 2010, 11:52 a.m., Sergey Ivanov wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Amarok.</div>
<div>By Sergey Ivanov.</div>
<p style="color: grey;"><i>Updated 2010-12-11 11:52:39</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Rewrite tag reading stuff to make It more OOP way. Add separat classes for each Tag format (ID3v2, APE, ASF, VorbisComment, MP4, MPC). Exclude almost all "magic words" (frame/field names) from code.
TODO:
Implement charset detection stuff.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>shared/FileType.h <span style="color: grey">(dc5e57b)</span></li>
<li>shared/FileType.cpp <span style="color: grey">(63d81c7)</span></li>
<li>shared/MetaTagLib.h <span style="color: grey">(ff27c92)</span></li>
<li>shared/MetaTagLib.cpp <span style="color: grey">(3f7e758)</span></li>
<li>shared/TagsFromFileNameGuesser.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>shared/TagsFromFileNameGuesser.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>shared/tag_helpers/APETagHelper.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>shared/tag_helpers/APETagHelper.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>shared/tag_helpers/ASFTagHelper.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>shared/tag_helpers/ASFTagHelper.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>shared/tag_helpers/ID3v2TagHelper.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>shared/tag_helpers/ID3v2TagHelper.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>shared/tag_helpers/MP4TagHelper.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>shared/tag_helpers/MP4TagHelper.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>shared/tag_helpers/StringHelper.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>shared/tag_helpers/StringHelper.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>shared/tag_helpers/TagHelper.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>shared/tag_helpers/TagHelper.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>shared/tag_helpers/VorbisCommentTagHelper.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>shared/tag_helpers/VorbisCommentTagHelper.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/CMakeLists.txt <span style="color: grey">(a23bbdb)</span></li>
<li>src/core-impl/meta/file/File_p.h <span style="color: grey">(9f1df54)</span></li>
<li>src/musicbrainz/MusicBrainzFinder.cpp <span style="color: grey">(78a07a6)</span></li>
<li>utilities/collectionscanner/CMakeLists.txt <span style="color: grey">(6be9319)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/100191/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>