[patch] Add PlayPause() to DBus interface

[Michael Zanetti]

Hi,

While having a second look at the code I noticed that Pause() already does 
exactly what I want: calling The::engineController()->playPause().

I've looked into the mpris spec and it says the following:
- Pause 
If playing : pause. If paused : unpause 
Introspection data: 
  <method name="Pause">
  </method>

So I guess my patch is not needed in this case.

Still, the relative seek function could be a useful addition. I have 
implemented them in a own branch at gitorious and issued the merge request.

Cheers,
Michael

On Sunday 06 September 2009 07:54:13 Seb Ruiz wrote:
> 2009/9/5 Michael Zanetti <michael_zanetti at gmx.net>:
> > Hi,
> >
> > Attached is a very small patch that adds the DBus function PlayPause().
> > This makes it possible to use amarok with IR remote controls that have
> > only a playPause button and no Pause or Stop buttons.
> >
> > I would love to see this in amarok. What do you think?
> 
> I think this is definitely a valid addition to the DBus api.
> 
> However, I'm going to put a big BUT here. There are two things that
> I'd like you to do before we can accept this patch:
> 
> 1. Conform to Amarok's hacking guideline. You can read about it here:
> http://bit.ly/13o06r
> 2. Grab an account at gitorious.org, clone the Amarok repository,
> apply your patch and then issue a merge request. This will allow us to
> use git to handle the commit review and you'll also be listed as the
> author of the patch!
> 
> Okay, I know that Number 2 could be considered overkill for this
> rather small patch, however we are trying to encourage patch
> contributors to use gitorious, as this significantly lowers barriers
> for future patches. It also is much easier for Amarok developers to
> keep track of patches and means that hopefully we won't lose patches
> in mailing list noise.
> 
> Best regards,
> Seb
>