SqlCollectionLocation::startNextJob() not properly copying files patch

Myriam Schweingruber schweingruber at pharma-traduction.ch
Wed Oct 7 09:16:04 CEST 2009


On Tue, Oct 6, 2009 at 06:47, Casey Jones <jonescaseyb at gmail.com> wrote:
> Hello
>
> I found a bug when I used the Organize Files option in the Collection
> browser.  When I tried organizing my files by Album, it copied a file out of
> each directory and moved it to the collection root and renamed it to what
> the new folder should have been.  I found that
> SqlCollectionLocation::startNextJob wasn't creating the directory because it
> was trying to make the collection root folder, which already existed instead
> of the Album folder in the collection root.
>
> Also, I created a new variable; KUrl finalDest, which is dest + the name of
> the file to copy.  My suspicion is that Kio::copy_file works like the cp
> command and needs the name of the file to copy, and not just the directory
> to put it in.
>
> The patch is attached.

Thank you, Casey.
Could somebody please have a look at this? It can potentially fix a
very ugly bug in the Organize files dialog. Thanks.


Regards, Myriam

-- 
Protect your freedom and join the Fellowship of FSFE:
http://www.fsfe.org
Please don't send me proprietary file formats,
use ISO standard ODF instead (ISO/IEC 26300)


More information about the Amarok-devel mailing list