SqlCollectionLocation::startNextJob() not properly copying files patch

[Mark Kretschmann]

On Wed, Oct 7, 2009 at 9:16 AM, Myriam Schweingruber
<schweingruber at pharma-traduction.ch> wrote:
> On Tue, Oct 6, 2009 at 06:47, Casey Jones <jonescaseyb at gmail.com> wrote:
>> I found a bug when I used the Organize Files option in the Collection
>> browser.  When I tried organizing my files by Album, it copied a file out of
>> each directory and moved it to the collection root and renamed it to what
>> the new folder should have been.  I found that
>> SqlCollectionLocation::startNextJob wasn't creating the directory because it
>> was trying to make the collection root folder, which already existed instead
>> of the Album folder in the collection root.
>>
>> Also, I created a new variable; KUrl finalDest, which is dest + the name of
>> the file to copy.  My suspicion is that Kio::copy_file works like the cp
>> command and needs the name of the file to copy, and not just the directory
>> to put it in.
>>
>> The patch is attached.
>
> Thank you, Casey.
> Could somebody please have a look at this? It can potentially fix a
> very ugly bug in the Organize files dialog. Thanks.

Yes, I will try to evaluate this patch today.

-- 
Mark Kretschmann
Amarok Developer
www.kde.org - amarok.kde.org