generate_changelog script

Magnus Bergmark magnus.bergmark at gmail.com
Thu May 21 19:59:45 CEST 2009


Okay, here's my first patch.

I intended this patch for fixing the obvious errors, making the file usable
again. I'm planning on another patch for generating correct XHTML - not just
HTML soup - and perhaps style the file a bit. If this other patch (or part
of it) would be unwelcome, please tell me so I don't waste time on it. :-)

Here's what I changed:

   - New file is generated without tag mismatching
   - Old versions parsed properly with bullet lists
   - HTML escaping in place. Email addresses shown correctly and so is
   amperstands
   - Some HTML guidelines followed (mostly header ording: document should
   have a h1, a h(n) must not be placed without a h(n-1) in the document)
   - Some old code paths greatly simplyfied
   - Some old code paths might be more complex to understand now, but that
   would be because I use regexps a little more. I've tried to comment
   extensivly to heighten maintainability and use extended mode regexps to make
   them more readable
   - Corrected the copyright notices, AFAIK about them

This makes the changes an almost complete rewrite, so I took the liberty to
add myself to the copyright notice. If this is unwanted, you might as well
remove it and I'd not complain.

Tell me what you think. This is my first path to Amarok and I'm learning C++
and Qt as we speak (I have Qt Creator open in another desktop) to continue
contributing to the main app.

PS. I also attached a sample output file. It's not the current ChangeLog,
but new enough.

On Thu, May 21, 2009 at 7:03 PM, Magnus Bergmark
<magnus.bergmark at gmail.com>wrote:

> Just wanted to add that I have been working on this since Mark's response.
> Progress is looking good. Will post a patch when I'm done. :-)
>
>
> On Thu, May 21, 2009 at 5:46 PM, Lydia Pintscher <lydia at kde.org> wrote:
>
>> On Thu, May 21, 2009 at 17:15, Mark Kretschmann <kretschmann at kde.org>
>> wrote:
>> > I think Lydia meant a commit to "generate_changelog.rb", not to
>> > "ChangeLog" itself. You can find the commit history here:
>> >
>> >
>> http://kollide.net:8060/browse/Amarok/release_scripts/generate_changelog.rb
>>
>> Yes, that's what I was talking about :)
>>
>>
>> Cheers
>> Lydia
>>
>> --
>> Lydia Pintscher
>> Amarok community manager
>> kde.org - amarok.kde.org - kubuntu.org
>> claimid.com/nightrose
>> _______________________________________________
>> Amarok-devel mailing list
>> Amarok-devel at kde.org
>> https://mail.kde.org/mailman/listinfo/amarok-devel
>>
>
>
>
> --
> Magnus Bergmark - magnus DOT bergmark AT gmail DOT com
> GPG/PGP: 0x7BE84794DB6AA648
> Fingerprint: 0E6F D2DB F0EF 534A 2184 52AF 7BE8 4794 DB6A A648
>



-- 
Magnus Bergmark - magnus DOT bergmark AT gmail DOT com
GPG/PGP: 0x7BE84794DB6AA648
Fingerprint: 0E6F D2DB F0EF 534A 2184 52AF 7BE8 4794 DB6A A648
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/amarok-devel/attachments/20090521/dc625e35/attachment-0001.htm 
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/amarok-devel/attachments/20090521/dc625e35/attachment-0001.html 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: generate_changelog.rb.patch
Type: text/x-patch
Size: 3781 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/amarok-devel/attachments/20090521/dc625e35/attachment-0001.patch 


More information about the Amarok-devel mailing list