Okay, here's my first patch.<br><br>I intended this patch for fixing the obvious errors, making the file usable again. I'm planning on another patch for generating correct XHTML - not just HTML soup - and perhaps style the file a bit. If this other patch (or part of it) would be unwelcome, please tell me so I don't waste time on it. :-)<br>
<br>Here's what I changed:<br><ul><li>New file is generated without tag mismatching</li><li>Old versions parsed properly with bullet lists</li><li>HTML escaping in place. Email addresses shown correctly and so is amperstands</li>
<li>Some HTML guidelines followed (mostly header ording: document should have a h1, a h(n) must not be placed without a h(n-1) in the document)</li><li>Some old code paths greatly simplyfied</li><li>Some old code paths might be more complex to understand now, but that would be because I use regexps a little more. I've tried to comment extensivly to heighten maintainability and use extended mode regexps to make them more readable</li>
<li>Corrected the copyright notices, AFAIK about them<br></li></ul>This makes the changes an almost complete rewrite, so I took the liberty to add myself to the copyright notice. If this is unwanted, you might as well remove it and I'd not complain.<br>
<br>Tell me what you think. This is my first path to Amarok and I'm learning C++ and Qt as we speak (I have Qt Creator open in another desktop) to continue contributing to the main app.<br><br>PS. I also attached a sample output file. It's not the current ChangeLog, but new enough.<br>
<br><div class="gmail_quote">On Thu, May 21, 2009 at 7:03 PM, Magnus Bergmark <span dir="ltr"><<a href="mailto:magnus.bergmark@gmail.com">magnus.bergmark@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
Just wanted to add that I have been working on this since Mark's response. Progress is looking good. Will post a patch when I'm done. :-)<div><div></div><div class="h5"><br><br><div class="gmail_quote">On Thu, May 21, 2009 at 5:46 PM, Lydia Pintscher <span dir="ltr"><<a href="mailto:lydia@kde.org" target="_blank">lydia@kde.org</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"><div>On Thu, May 21, 2009 at 17:15, Mark Kretschmann <<a href="mailto:kretschmann@kde.org" target="_blank">kretschmann@kde.org</a>> wrote:<br>
> I think Lydia meant a commit to "generate_changelog.rb", not to<br>
> "ChangeLog" itself. You can find the commit history here:<br>
><br>
> <a href="http://kollide.net:8060/browse/Amarok/release_scripts/generate_changelog.rb" target="_blank">http://kollide.net:8060/browse/Amarok/release_scripts/generate_changelog.rb</a><br>
<br>
</div>Yes, that's what I was talking about :)<br>
<div><br>
<br>
Cheers<br>
Lydia<br>
<br>
--<br>
Lydia Pintscher<br>
Amarok community manager<br>
<a href="http://kde.org" target="_blank">kde.org</a> - <a href="http://amarok.kde.org" target="_blank">amarok.kde.org</a> - <a href="http://kubuntu.org" target="_blank">kubuntu.org</a><br>
<a href="http://claimid.com/nightrose" target="_blank">claimid.com/nightrose</a><br>
_______________________________________________<br>
</div><div><div></div><div>Amarok-devel mailing list<br>
<a href="mailto:Amarok-devel@kde.org" target="_blank">Amarok-devel@kde.org</a><br>
<a href="https://mail.kde.org/mailman/listinfo/amarok-devel" target="_blank">https://mail.kde.org/mailman/listinfo/amarok-devel</a><br>
</div></div></blockquote></div><br><br clear="all"><br></div></div><div><div></div><div class="h5">-- <br>Magnus Bergmark - magnus DOT bergmark AT gmail DOT com<br>GPG/PGP: 0x7BE84794DB6AA648<br>Fingerprint: 0E6F D2DB F0EF 534A 2184 52AF 7BE8 4794 DB6A A648<br>
</div></div></blockquote></div><br><br clear="all"><br>-- <br>Magnus Bergmark - magnus DOT bergmark AT gmail DOT com<br>GPG/PGP: 0x7BE84794DB6AA648<br>Fingerprint: 0E6F D2DB F0EF 534A 2184 52AF 7BE8 4794 DB6A A648<br>