extragear/multimedia/amarok/src/context [POSSIBLY UNSAFE]

[Jeff Mitchell]

Dan Meltzer wrote:
> On Wed, May 6, 2009 at 6:22 PM, Jeff Mitchell <mitchell at kde.org> wrote:
>> SVN commit 964573 by mitchell:
>>
>> Add songkick engine/applet.  Not built by default, but leo is going to help me figure out why it's crashing Amarok on exit (if you do build it).  No i18ns, so doesn't affect string freeze.
> 
> I object to this.
> 
> 1) It has strings.  Not translating them just so that it doesn't break
> the string freeze doesn't make it any better. They still show up
> poorly for users of other languages.

No, it doesn't, because it's not getting built.

> 2) It does break the feature freeze.  We are gearing up for a release,
> not adding more features.

It's already been living in our source tree for six months.  I just
moved it and touched it up a bit because I wanted to see if their API
was still working.

> 3) Is this really worht shipping by default? It could be easily put on
> kde-apps.org

So could our lyrics applet.  Or Wikipedia.

--Jeff

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 260 bytes
Desc: OpenPGP digital signature
Url : http://mail.kde.org/pipermail/amarok-devel/attachments/20090506/a0ee96df/attachment.sig