extragear/multimedia/amarok/src/context [POSSIBLY UNSAFE]

[Dan Meltzer]

On Wed, May 6, 2009 at 6:22 PM, Jeff Mitchell <mitchell at kde.org> wrote:
> SVN commit 964573 by mitchell:
>
> Add songkick engine/applet.  Not built by default, but leo is going to help me figure out why it's crashing Amarok on exit (if you do build it).  No i18ns, so doesn't affect string freeze.

I object to this.

1) It has strings.  Not translating them just so that it doesn't break
the string freeze doesn't make it any better. They still show up
poorly for users of other languages.

2) It does break the feature freeze.  We are gearing up for a release,
not adding more features.

3) Is this really worht shipping by default? It could be easily put on
kde-apps.org

Dan,
>
>
>  M  +1 -0      applets/CMakeLists.txt
>  A             applets/songkick (directory)
>  A             applets/songkick/CMakeLists.txt
>  A             applets/songkick/SongkickApplet.cpp   [License: GPL (v2+)]
>  A             applets/songkick/SongkickApplet.h   [License: GPL (v2+)]
>  A             applets/songkick/amarok-context-applet-songkick.desktop
>  M  +0 -1      engines/CMakeLists.txt
>  A             engines/songkick (directory)
>  A             engines/songkick/CMakeLists.txt
>  A             engines/songkick/JsonQt (directory)
>  A             engines/songkick/JsonQt/CMakeLists.txt
>  A             engines/songkick/JsonQt/COMPATIBILITY
>  A             engines/songkick/JsonQt/COPYING.HEADER
>  A             engines/songkick/JsonQt/Doxyfile.cmake
>  A             engines/songkick/JsonQt/README.txt
>  A             engines/songkick/JsonQt/add-copyright-header.sh
>  A             engines/songkick/JsonQt/lib (directory)
>  A             engines/songkick/JsonQt/lib/CMakeLists.txt
>  A             engines/songkick/JsonQt/lib/JsonQtExport.h   [License: UNKNOWN]
>  A             engines/songkick/JsonQt/lib/JsonRpc.cpp   [License: UNKNOWN]
>  A             engines/songkick/JsonQt/lib/JsonRpc.h   [License: UNKNOWN]
>  A             engines/songkick/JsonQt/lib/JsonRpcAdaptor.cpp   [License: UNKNOWN]
>  A             engines/songkick/JsonQt/lib/JsonRpcAdaptor.h   [License: UNKNOWN]
>  A             engines/songkick/JsonQt/lib/JsonRpcAdaptorPrivate.cpp   [License: UNKNOWN]
>  A             engines/songkick/JsonQt/lib/JsonRpcAdaptorPrivate.h   [License: UNKNOWN]
>  A             engines/songkick/JsonQt/lib/JsonToProperties.cpp   [License: UNKNOWN]
>  A             engines/songkick/JsonQt/lib/JsonToProperties.h   [License: UNKNOWN]
>  A             engines/songkick/JsonQt/lib/JsonToVariant.cpp   [License: UNKNOWN]
>  A             engines/songkick/JsonQt/lib/JsonToVariant.h   [License: UNKNOWN]
>  A             engines/songkick/JsonQt/lib/ParseException.cpp   [License: UNKNOWN]
>  A             engines/songkick/JsonQt/lib/ParseException.h   [License: UNKNOWN]
>  A             engines/songkick/JsonQt/lib/VariantToJson.cpp   [License: UNKNOWN]
>  A             engines/songkick/JsonQt/lib/VariantToJson.h   [License: UNKNOWN]
>  A             engines/songkick/JsonQt/tests (directory)
>  A             engines/songkick/JsonQt/tests/CMakeLists.txt
>  A             engines/songkick/JsonQt/tests/JsonRpc.cpp   [License: UNKNOWN]
>  A             engines/songkick/JsonQt/tests/JsonRpcAdaptor.cpp   [License: UNKNOWN]
>  A             engines/songkick/JsonQt/tests/JsonToProperties.cpp   [License: UNKNOWN]
>  A             engines/songkick/JsonQt/tests/JsonToVariant.cpp   [License: UNKNOWN]
>  A             engines/songkick/JsonQt/tests/VariantToJson.cpp   [License: UNKNOWN]
>  A             engines/songkick/SongkickEngine.cpp   [POSSIBLY UNSAFE: system] [License: GPL (v2+)]
>  A             engines/songkick/SongkickEngine.h   [License: GPL (v2+)]
>  A             engines/songkick/amarok-data-engine-songkick.desktop
>
>
> --- trunk/extragear/multimedia/amarok/src/context/applets/CMakeLists.txt #964572:964573
> @@ -5,3 +5,4 @@
>  add_subdirectory( serviceinfo )
>  add_subdirectory( wikipedia )
>  add_subdirectory( mediadevices )
> +#add_subdirectory( songkick )
> --- trunk/extragear/multimedia/amarok/src/context/engines/CMakeLists.txt #964572:964573
> @@ -3,4 +3,3 @@
>  add_subdirectory( current )
>  add_subdirectory( service )
>  #add_subdirectory( songkick )
> -
>