Patches for OpenSolaris

[Adriaan de Groot]

Here at CampKDE I showed the Amarok dudes how it would run on OpenSolaris; it 
does take a fistful of patches (mostly simple ones). Casey suggested I 
actually send them in instead of blogging only :)

The three const-match patches make declaration and definition of various 
methods match in terms of constness; gcc thinks this is fine, but for 
compliers that consider constness in resolution or linking, this is a problem.

Free is in <stdlib.h> and doesn't necessarily live in the :: namespace.

The findmysql one is possibly not suitable for inclusion -- it adds some more 
search paths and things to find MySQL in the default install locations on 
Solaris.

The md5 code uses the linux kernel types u_int32_t instead of standard integer 
types like uint32_t.

namespace foo { extern bar; } gives me a foo::bar symbol instead of a ::bar 
symbol, so the namespace patch moves one extern around. 

The scriptengine has some constness issues and a ; too many. I think Casey has 
already committed that last one.

The amarok-wide patch is rather klumky, since it just forces in the Solaris 
wide character functions instead of doing some suitable conditional 
compilation. I'd be ok with maintaing this one separately.

The DEBUG_BLOCK macro uses the gcc-ism __PRETTY_FUNCTION__; see qdebug for one 
way of dealing with this instead. I've gone for the boring approach of 
#defining it to a string that is semi-sort-of-meaningful.

Finally, no-webkit removes WebKit from linking, because it conflicts with kjs 
in KDE -- those are harmless collissions, i think, but it's annoying to see 
all those show up on linking.

[ade]
-------------- next part --------------
A non-text attachment was scrubbed...
Name: amarok-const-match.2.diff
Type: text/x-patch
Size: 370 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/amarok-devel/attachments/20090121/ee5decea/attachment.diff 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: amarok-const-match.3.diff
Type: text/x-patch
Size: 786 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/amarok-devel/attachments/20090121/ee5decea/attachment-0001.diff 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: amarok-const-match.diff
Type: text/x-patch
Size: 406 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/amarok-devel/attachments/20090121/ee5decea/attachment-0002.diff 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: amarok-free-stdlib.diff
Type: text/x-patch
Size: 445 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/amarok-devel/attachments/20090121/ee5decea/attachment-0003.diff 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: amarok-findmysql.diff
Type: text/x-patch
Size: 540 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/amarok-devel/attachments/20090121/ee5decea/attachment-0004.diff 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: amarok-linuxism-uint.diff
Type: text/x-patch
Size: 3852 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/amarok-devel/attachments/20090121/ee5decea/attachment-0005.diff 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: amarok-namespaced-extern.diff
Type: text/x-patch
Size: 447 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/amarok-devel/attachments/20090121/ee5decea/attachment-0006.diff 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: amarok-scriptengine-const-ref.diff
Type: text/x-patch
Size: 869 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/amarok-devel/attachments/20090121/ee5decea/attachment-0007.diff 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: amarok-scriptengine-syntax.diff
Type: text/x-patch
Size: 407 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/amarok-devel/attachments/20090121/ee5decea/attachment-0008.diff 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: amarok-wide.diff
Type: text/x-patch
Size: 948 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/amarok-devel/attachments/20090121/ee5decea/attachment-0009.diff 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: amarok-debug.diff
Type: text/x-patch
Size: 678 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/amarok-devel/attachments/20090121/ee5decea/attachment-0010.diff 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: amarok-no-webkit.diff
Type: text/x-patch
Size: 293 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/amarok-devel/attachments/20090121/ee5decea/attachment-0011.diff