Crash during playback

Mark Kretschmann kretschmann at kde.org
Sat Feb 14 12:31:26 CET 2009


On Sat, Feb 14, 2009 at 12:19 PM, Alex Merry <kde at randomguy3.me.uk> wrote:
> On Saturday 14 February 2009 10:54:20 Alex Merry wrote:
>> On Saturday 14 February 2009 09:24:37 Mark Kretschmann wrote:
>> > On Sat, Feb 14, 2009 at 9:49 AM, Mark Kretschmann <kretschmann at kde.org>
>>
>> wrote:
>> > Fixed it. Problem was a missing isNull() check on a QPixmap that was
>> > being rendered. However, one has to wonder why QPainter does not do
>> > this check internally...
>>
>> It should do (I've run into this sort of problem before, although in that
>> case QPainter _was_ doing the check, but QPixmap was lying).  That sounds
>> like a Qt bug to me.
>
> In fact, Qt 4.5 in qt-copy (unpatched) has a null pixmap check in the
> QPainter::drawPixmap(QRectF,QPixmap,QRectF) method.  So I don't think you've
> fixed the issue, since as far as I can see your check is effectively a no-op.

FWIW, I'm using Qt 4.4.

-- 
Mark Kretschmann
Amarok Developer
www.kde.org - amarok.kde.org


More information about the Amarok-devel mailing list