Fwd: Re: [Amarok-devel] Initial discussion

[Maximilian Kossick]

Just forwarding Alexandre's reply to my e-mail to the list.

----------  Forwarded message  ----------

Subject: Re: [Amarok-devel] Initial discussion
Date: Sunday 18 February 2007
From: "Alexandre Oliveira" <aleprjlists at gmail.com>
To: "Maximilian Kossick" <mkossick at gmx.de>

On 2/18/07, Maximilian Kossick <mkossick at gmx.de> wrote:
>> They all inheriting a base object would be useful for some
> > stuff as well.
>
> I agree. We should replace MetaBundle completely. I'm not quite sure what 
you
> mean by "inheriting a base object". Do you already know a case where a 
common
> base class would be useful?

Yeah, If they all have a common base, and they all have methods such
as prettyText() and compare stuff, we could use them directly in the
browsers, playlist, and etc, without needing to handle them
differenty. Pretty much the way you just send objects to Swing objects
in java, and they just use the toString() method to know what to show.

> > 3) Reduce developers compiling time.
> > I don't mean we should do any magic regarding this, I only mean we
> > should split the amarok lib we have now, so stuff can depend only on
> > what they really need, so we don't relink everything whenever
> > something that doesn't matter changes.
>
> We have a few classes which are used that much that a change to the header
> file basically requires recompiling all of amarok. How about adding
> d-pointers to classes like EngineController, CollectionDB or Playlist ( or
> their replacements) so that we can add members without having to change the
> header files?

I was refering more to linking time. In 1.4 you change, for example,
something in OSD, and all engines, device plugins, media device
plugins, and everything else have to link again, and it used to take
quite some time. It feels faster now though, maybe it's because most
of them are disabled.

> I don't think we have 5000 line methods,  but 500 line methods and 5000 line
> classes for sure. And neither is a good idea:)

The method that handled the context menu on playlistbrowser had more
than 5000 before I split it, not so long ago :-(

-------------------------------------------------------
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/amarok-devel/attachments/20070219/3b8c089c/attachment.pgp