extragear/multimedia/amarok/src/servicebrowser

[Nikolaj Hald Nielsen]

Maximilian,

I appreciate you fixing some of the errors and omissions in this service
related code, but I am currently working on completely restructuring how
this works, as the different content items and models currently share a
ridiculous amount of code, so it might be too early to do a cleanup of this
code as it might change dramatically over the next week or so.

I am not even sure that there will be separate Jamendo and Magnatune content
items when I am done :-)

I was actually thinking something along the lines of having a generic model
and content item and then plugging in the correct database hander and xml
parser (based on mainly abstract subclasses) for a specific service. This
will make it much easier to add new services at you will not have to create
a new model and new content items unleyy you wanted to subclass them to add
really specific functionality.

- Nikolaj

On 4/25/07, Maximilian Kossick <maximilian.kossick at googlemail.com> wrote:
>
> SVN commit 657749 by mkossick:
>
> added virtual destructors
> delete child items in the dtor of servicemodelbase, makes more sense there
> than in sub-classes
>
> M  +0 -1      jamendo/jamendocontentitem.cpp
> M  +1 -1      jamendo/jamendocontentitem.h
> M  +0 -1      magnatunestore/magnatunecontentitem.cpp
> M  +1 -1      magnatunestore/magnatunecontentitem.h
>
>
> ---
> trunk/extragear/multimedia/amarok/src/servicebrowser/jamendo/jamendocontentitem.cpp
> #657748:657749
> @@ -70,7 +70,6 @@
>
>   JamendoContentItem::~JamendoContentItem()
>   {
> -     qDeleteAll(m_childItems);
>   }
>
>   JamendoContentItem *JamendoContentItem::child(int row)
> ---
> trunk/extragear/multimedia/amarok/src/servicebrowser/jamendo/jamendocontentitem.h
> #657748:657749
> @@ -48,7 +48,7 @@
>
>
>
> -    ~JamendoContentItem();
> +    virtual ~JamendoContentItem();
>
>      JamendoContentItem *child(int row);
>      int childCount() const;
> ---
> trunk/extragear/multimedia/amarok/src/servicebrowser/magnatunestore/magnatunecontentitem.cpp
> #657748:657749
> @@ -71,7 +71,6 @@
>
>   MagnatuneContentItem::~MagnatuneContentItem()
>   {
> -     qDeleteAll(m_childItems);
>   }
>
>   MagnatuneContentItem *MagnatuneContentItem::child(int row)
> ---
> trunk/extragear/multimedia/amarok/src/servicebrowser/magnatunestore/magnatunecontentitem.h
> #657748:657749
> @@ -49,7 +49,7 @@
>
>
>
> -    ~MagnatuneContentItem();
> +    virtual ~MagnatuneContentItem();
>
>      MagnatuneContentItem *child(int row);
>      int childCount() const;
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/amarok-devel/attachments/20070425/7b6901ce/attachment.html