<span class="gmail_quote"></span><span class="gmail_quote">Maximilian, <br><br>I appreciate you fixing some of the errors and omissions in this service related code, but I am currently working on completely restructuring how this works, as the different content items and models currently share a ridiculous amount of code, so it might be too early to do a cleanup of this code as it might change dramatically over the next week or so.
<br><br>I am not even sure that there will be separate Jamendo and Magnatune content items when I am done :-)<br><br>I was actually thinking something along the lines of having a generic model and content item and then plugging in the correct database hander and xml parser (based on mainly abstract subclasses) for a specific service. This will make it much easier to add new services at you will not have to create a new model and new content items unleyy you wanted to subclass them to add really specific functionality.
<br><br>- Nikolaj<br></span><br><div><span class="gmail_quote">On 4/25/07, <b class="gmail_sendername">Maximilian Kossick</b> <<a href="mailto:maximilian.kossick@googlemail.com">maximilian.kossick@googlemail.com</a>> wrote:
</span><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">SVN commit 657749 by mkossick:<br><br>added virtual destructors<br>delete child items in the dtor of servicemodelbase, makes more sense there than in sub-classes
<br><br> M +0 -1 jamendo/jamendocontentitem.cpp<br> M +1 -1 jamendo/jamendocontentitem.h<br> M +0 -1 magnatunestore/magnatunecontentitem.cpp<br> M +1 -1 magnatunestore/magnatunecontentitem.h<br><br>
<br>--- trunk/extragear/multimedia/amarok/src/servicebrowser/jamendo/jamendocontentitem.cpp #657748:657749<br>@@ -70,7 +70,6 @@<br><br> JamendoContentItem::~JamendoContentItem()<br> {<br>- qDeleteAll(m_childItems);<br>
}<br><br> JamendoContentItem *JamendoContentItem::child(int row)<br>--- trunk/extragear/multimedia/amarok/src/servicebrowser/jamendo/jamendocontentitem.h #657748:657749<br>@@ -48,7 +48,7 @@<br><br><br><br>- ~JamendoContentItem();
<br>+ virtual ~JamendoContentItem();<br><br> JamendoContentItem *child(int row);<br> int childCount() const;<br>--- trunk/extragear/multimedia/amarok/src/servicebrowser/magnatunestore/magnatunecontentitem.cpp #657748:657749
<br>@@ -71,7 +71,6 @@<br><br> MagnatuneContentItem::~MagnatuneContentItem()<br> {<br>- qDeleteAll(m_childItems);<br> }<br><br> MagnatuneContentItem *MagnatuneContentItem::child(int row)<br>--- trunk/extragear/multimedia/amarok/src/servicebrowser/magnatunestore/magnatunecontentitem.h #657748:657749
<br>@@ -49,7 +49,7 @@<br><br><br><br>- ~MagnatuneContentItem();<br>+ virtual ~MagnatuneContentItem();<br><br> MagnatuneContentItem *child(int row);<br> int childCount() const;<br></blockquote></div><br>