Review Request 110287: fix some issues in the sql script and move away from the npm scripts functionality

[Giorgos Tsiapaliokas]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110287/
-----------------------------------------------------------

(Updated May 4, 2013, 10:20 a.m.)


Review request for Bodega.


Changes
-------

* check if the element is undefined, otherwise the shift method skips the last element of the array
* add again the vivaldi.sql file, without it the user can't authorize because this query

> SELECT u.id, u.fullname, u.email, u.active, u.points + u.owedPoints as points, u.password FROM people u JOIN devices d ON (d.partNumber = 'VIVALDI-1') WHERE  > u.email = 'terietor at gmail.com';

returns 0 rows.
This query is being executed in server/lib/db/authorize.js:36


Description
-------

Hello,

this patch does

1. it requires 3 parameters now instead of 1.
The new parameters are the config.json filepath, the sql dir and the sql command.
2. it removes the npm scripts functionality

check this issue https://github.com/isaacs/npm/issues/3370#issuecomment-16892283

3. it adds the sql functionality into the makefile.


Diffs (updated)
-----

  server/Makefile a35b309 
  server/package.json 3ee556d 
  sql/do_sql 93bf764 

Diff: http://git.reviewboard.kde.org/r/110287/diff/


Testing
-------


Thanks,

Giorgos Tsiapaliokas

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/active/attachments/20130504/aa2cce91/attachment-0001.html>