Review Request 110287: fix some issues in the sql script and move away from the npm scripts functionality
Aaron J. Seigo
aseigo at kde.org
Sat May 4 16:45:49 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110287/#review32018
-----------------------------------------------------------
sql/do_sql
<http://git.reviewboard.kde.org/r/110287/#comment23856>
vivaldi.sql should not be part of the default setup. this is part of our specific installation on mpl.
- Aaron J. Seigo
On May 4, 2013, 10:20 a.m., Giorgos Tsiapaliokas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110287/
> -----------------------------------------------------------
>
> (Updated May 4, 2013, 10:20 a.m.)
>
>
> Review request for Bodega.
>
>
> Description
> -------
>
> Hello,
>
> this patch does
>
> 1. it requires 3 parameters now instead of 1.
> The new parameters are the config.json filepath, the sql dir and the sql command.
> 2. it removes the npm scripts functionality
>
> check this issue https://github.com/isaacs/npm/issues/3370#issuecomment-16892283
>
> 3. it adds the sql functionality into the makefile.
>
>
> Diffs
> -----
>
> server/Makefile a35b309
> server/package.json 3ee556d
> sql/do_sql 93bf764
>
> Diff: http://git.reviewboard.kde.org/r/110287/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Giorgos Tsiapaliokas
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/active/attachments/20130504/36a1e42a/attachment.html>
More information about the Active
mailing list