<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/110287/">http://git.reviewboard.kde.org/r/110287/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Bodega.</div>
<div>By Giorgos Tsiapaliokas.</div>
<p style="color: grey;"><i>Updated May 4, 2013, 10:20 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">* check if the element is undefined, otherwise the shift method skips the last element of the array
* add again the vivaldi.sql file, without it the user can't authorize because this query
> SELECT u.id, u.fullname, u.email, u.active, u.points + u.owedPoints as points, u.password FROM people u JOIN devices d ON (d.partNumber = 'VIVALDI-1') WHERE > u.email = 'terietor@gmail.com';
returns 0 rows.
This query is being executed in server/lib/db/authorize.js:36
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Hello,
this patch does
1. it requires 3 parameters now instead of 1.
The new parameters are the config.json filepath, the sql dir and the sql command.
2. it removes the npm scripts functionality
check this issue https://github.com/isaacs/npm/issues/3370#issuecomment-16892283
3. it adds the sql functionality into the makefile.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>server/Makefile <span style="color: grey">(a35b309)</span></li>
<li>server/package.json <span style="color: grey">(3ee556d)</span></li>
<li>sql/do_sql <span style="color: grey">(93bf764)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/110287/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>