Review Request 111369: add support for the collection in the active-addons

Giorgos Tsiapaliokas terietor at gmail.com
Fri Jul 5 13:23:00 UTC 2013



> On July 3, 2013, 9:10 a.m., Aaron J. Seigo wrote:
> > activeclient/src/bodegastore.cpp, line 310
> > <http://git.reviewboard.kde.org/r/111369/diff/1/?file=167597#file167597line310>
> >
> >     this can be changed in your local configuration, but should not be changed in the code.

yes, this one was a leftover


- Giorgos


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111369/#review35491
-----------------------------------------------------------


On July 2, 2013, 6:05 p.m., Giorgos Tsiapaliokas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111369/
> -----------------------------------------------------------
> 
> (Updated July 2, 2013, 6:05 p.m.)
> 
> 
> Review request for Bodega.
> 
> 
> Description
> -------
> 
> This patch adds support for the collections in the active-addons.
> 
> 
> Diffs
> -----
> 
>   activeclient/package/contents/ui/storebrowser/ListBallotsJobColumn.qml PRE-CREATION 
>   activeclient/package/contents/ui/storebrowser/ListBallotAssetsJobColumn.qml PRE-CREATION 
>   activeclient/package/contents/ui/storebrowser/ItemBrowser.qml 1ba83bf 
>   activeclient/package/contents/ui/storebrowser/OverviewColumn.qml 8befff5 
>   activeclient/src/bodegastore.h a305d11 
>   activeclient/src/bodegastore.cpp 78ded47 
>   lib/CMakeLists.txt 381c03f 
>   lib/bodega/CMakeLists.txt 1ecc498 
>   lib/bodega/ballotlistassetsjob.cpp 9492f25 
>   lib/bodega/ballotlistassetsjobmodel.h PRE-CREATION 
>   lib/bodega/ballotlistassetsjobmodel.cpp PRE-CREATION 
>   lib/bodega/listballotsjob.cpp 00bf45c 
>   lib/bodega/listballotsjobmodel.h PRE-CREATION 
>   lib/bodega/listballotsjobmodel.cpp PRE-CREATION 
>   lib/bodega/session.cpp 6998da8 
> 
> Diff: http://git.reviewboard.kde.org/r/111369/diff/
> 
> 
> Testing
> -------
> 
> I have tested the active-addons with the testdata
> 
> 
> File Attachments
> ----------------
> 
> 
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/07/02/bodega-collection-native.png
> 
> 
> Thanks,
> 
> Giorgos Tsiapaliokas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/active/attachments/20130705/26d07722/attachment.html>


More information about the Active mailing list