<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/111369/">http://git.reviewboard.kde.org/r/111369/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On July 3rd, 2013, 9:10 a.m. UTC, <b>Aaron J. Seigo</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/111369/diff/1/?file=167597#file167597line310" style="color: black; font-weight: bold; text-decoration: underline;">activeclient/src/bodegastore.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">BodegaStore::BodegaStore()</pre></td>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void participantInfoFromQScriptValue(const QScriptValue &scriptValue, Bodega::ParticipantInfo &info)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">302</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">m_session</span><span class="o">-></span><span class="n">setBaseUrl</span><span class="p">(</span><span class="n">config</span><span class="p">.</span><span class="n">readEntry</span><span class="p">(</span><span class="s">"URL"</span><span class="p">,</span> <span class="s">"http://<span class="hl">addons.makeplaylive.com</span>:3000"</span><span class="p">));</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">308</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">m_session</span><span class="o">-></span><span class="n">setBaseUrl</span><span class="p">(</span><span class="n">config</span><span class="p">.</span><span class="n">readEntry</span><span class="p">(</span><span class="s">"URL"</span><span class="p">,</span> <span class="s">"http://<span class="hl">localhost</span>:3000"</span><span class="p">));</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">this can be changed in your local configuration, but should not be changed in the code.</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">yes, this one was a leftover</pre>
<br />
<p>- Giorgos</p>
<br />
<p>On July 2nd, 2013, 6:05 p.m. UTC, Giorgos Tsiapaliokas wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Bodega.</div>
<div>By Giorgos Tsiapaliokas.</div>
<p style="color: grey;"><i>Updated July 2, 2013, 6:05 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch adds support for the collections in the active-addons.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I have tested the active-addons with the testdata</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>activeclient/package/contents/ui/storebrowser/ListBallotsJobColumn.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>activeclient/package/contents/ui/storebrowser/ListBallotAssetsJobColumn.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>activeclient/package/contents/ui/storebrowser/ItemBrowser.qml <span style="color: grey">(1ba83bf)</span></li>
<li>activeclient/package/contents/ui/storebrowser/OverviewColumn.qml <span style="color: grey">(8befff5)</span></li>
<li>activeclient/src/bodegastore.h <span style="color: grey">(a305d11)</span></li>
<li>activeclient/src/bodegastore.cpp <span style="color: grey">(78ded47)</span></li>
<li>lib/CMakeLists.txt <span style="color: grey">(381c03f)</span></li>
<li>lib/bodega/CMakeLists.txt <span style="color: grey">(1ecc498)</span></li>
<li>lib/bodega/ballotlistassetsjob.cpp <span style="color: grey">(9492f25)</span></li>
<li>lib/bodega/ballotlistassetsjobmodel.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>lib/bodega/ballotlistassetsjobmodel.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>lib/bodega/listballotsjob.cpp <span style="color: grey">(00bf45c)</span></li>
<li>lib/bodega/listballotsjobmodel.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>lib/bodega/listballotsjobmodel.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>lib/bodega/session.cpp <span style="color: grey">(6998da8)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/111369/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<ul>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/07/02/bodega-collection-native.png">bodega-collection-native.png</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>