Review Request 111369: add support for the collection in the active-addons

[Aaron J. Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111369/#review35491
-----------------------------------------------------------


i see that the job is currently called BallotJob; apparently this was added by Zack when the feature was called "ballots" in the server. since then the API has changed to refer to them as collections. for ease of terminology and consistency, all occurrences of "Ballot" should be changed to "Collection" 


activeclient/src/bodegastore.cpp
<http://git.reviewboard.kde.org/r/111369/#comment26032>

    this can be changed in your local configuration, but should not be changed in the code.



lib/bodega/ballotlistassetsjobmodel.cpp
<http://git.reviewboard.kde.org/r/111369/#comment26036>

    this should have the same set of roles for assets that BodegaModel has, namely:
    
    AssetIdRole
    AssetLicenseRole
    AssetPartnerIdRole
    AssetPartnerNameRole
    AssetNameRole
    AssetVersionRole
    AssetFilenameRole
    AssetDescriptionRole
    AssetPointsRole
    


- Aaron J. Seigo


On July 2, 2013, 6:05 p.m., Giorgos Tsiapaliokas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111369/
> -----------------------------------------------------------
> 
> (Updated July 2, 2013, 6:05 p.m.)
> 
> 
> Review request for Bodega.
> 
> 
> Description
> -------
> 
> This patch adds support for the collections in the active-addons.
> 
> 
> Diffs
> -----
> 
>   activeclient/package/contents/ui/storebrowser/ListBallotsJobColumn.qml PRE-CREATION 
>   activeclient/package/contents/ui/storebrowser/ListBallotAssetsJobColumn.qml PRE-CREATION 
>   activeclient/package/contents/ui/storebrowser/ItemBrowser.qml 1ba83bf 
>   activeclient/package/contents/ui/storebrowser/OverviewColumn.qml 8befff5 
>   activeclient/src/bodegastore.h a305d11 
>   activeclient/src/bodegastore.cpp 78ded47 
>   lib/CMakeLists.txt 381c03f 
>   lib/bodega/CMakeLists.txt 1ecc498 
>   lib/bodega/ballotlistassetsjob.cpp 9492f25 
>   lib/bodega/ballotlistassetsjobmodel.h PRE-CREATION 
>   lib/bodega/ballotlistassetsjobmodel.cpp PRE-CREATION 
>   lib/bodega/listballotsjob.cpp 00bf45c 
>   lib/bodega/listballotsjobmodel.h PRE-CREATION 
>   lib/bodega/listballotsjobmodel.cpp PRE-CREATION 
>   lib/bodega/session.cpp 6998da8 
> 
> Diff: http://git.reviewboard.kde.org/r/111369/diff/
> 
> 
> Testing
> -------
> 
> I have tested the active-addons with the testdata
> 
> 
> File Attachments
> ----------------
> 
> 
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/07/02/bodega-collection-native.png
> 
> 
> Thanks,
> 
> Giorgos Tsiapaliokas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/active/attachments/20130703/d3299550/attachment.html>