[rekonq] Re: Review Request: Adds an option in configure dialog to disable the feature of saving password and login info in KDE wallet

[Tirtha Chatterjee]

> On May 10, 2011, 10:11 p.m., Andrea Diamantini wrote:
> > Let me say in general I hate our actual configuration dialog, that is increasing in an incredible way. I'd really like having a super simple one (with no more than 10 options).
> 
> Tirtha Chatterjee wrote:
>     someone told me that it is already possible to prevent storing of passwords by disconnecting Rekonq from KWallet. Is it so? In that case this patch would not be needed.
> 
> Andrea Diamantini wrote:
>     Not sure to understand this last. Can you please explain more precisely?
>     
>     
>     
>     
>     
>     
>     
>     
>     
>     
>     
>

When I blogged about this change, someone posted this as a comment - "I might be missing something, but isn’t the functionality you seek already in the KWallet application?
If you don’t want to store passwords, you can uncheck the Enable KDE Wallet System box. If you only want to prevent Rekonq passwords, Disconnect the app from the wallet, and/or cancel the kwallet password prompt when in rekonq."

I am not being able to test it because KWalletManager is not running for me. But it seems that if Rekonq is banned(disconnected) from KWallet, then the KWebWallet signals will stop, so this patch would not be needed. I do not have a lot of idea about KWallet. Can anyone verify this statement?


- Tirtha


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101317/#review3252
-----------------------------------------------------------


On May 8, 2011, 9:44 p.m., Tirtha Chatterjee wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101317/
> -----------------------------------------------------------
> 
> (Updated May 8, 2011, 9:44 p.m.)
> 
> 
> Review request for rekonq.
> 
> 
> Summary
> -------
> 
> This patch adds an option in the 'Configure Rekonq...' dialog in the General tab to 'use the KDE wallet to store login information'. This is enabled by default, but now can be turned off, so that the 'store password for ...?' prompt does not appear.
> 
> 
> Diffs
> -----
> 
>   src/rekonq.kcfg dba770b 
>   src/settings/settings_general.ui 0b27dab 
>   src/webtab.cpp 0994017 
> 
> Diff: http://git.reviewboard.kde.org/r/101317/diff
> 
> 
> Testing
> -------
> 
> Testing done. Works properly.
> 
> 
> Screenshots
> -----------
> 
> The 'Configure Rekonq...' dialog
>   http://git.reviewboard.kde.org/r/101317/s/160/
> 
> 
> Thanks,
> 
> Tirtha
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/rekonq/attachments/20110511/0296de81/attachment.htm