<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/101317/">http://git.reviewboard.kde.org/r/101317/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On May 10th, 2011, 10:11 p.m., <b>Andrea Diamantini</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Let me say in general I hate our actual configuration dialog, that is increasing in an incredible way. I'd really like having a super simple one (with no more than 10 options).</pre>
</blockquote>
<p>On May 11th, 2011, 9:35 a.m., <b>Tirtha Chatterjee</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">someone told me that it is already possible to prevent storing of passwords by disconnecting Rekonq from KWallet. Is it so? In that case this patch would not be needed.</pre>
</blockquote>
<p>On May 11th, 2011, 9:34 p.m., <b>Andrea Diamantini</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Not sure to understand this last. Can you please explain more precisely?
</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">When I blogged about this change, someone posted this as a comment - "I might be missing something, but isn’t the functionality you seek already in the KWallet application?
If you don’t want to store passwords, you can uncheck the Enable KDE Wallet System box. If you only want to prevent Rekonq passwords, Disconnect the app from the wallet, and/or cancel the kwallet password prompt when in rekonq."
I am not being able to test it because KWalletManager is not running for me. But it seems that if Rekonq is banned(disconnected) from KWallet, then the KWebWallet signals will stop, so this patch would not be needed. I do not have a lot of idea about KWallet. Can anyone verify this statement?</pre>
<br />
<p>- Tirtha</p>
<br />
<p>On May 8th, 2011, 9:44 p.m., Tirtha Chatterjee wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for rekonq.</div>
<div>By Tirtha Chatterjee.</div>
<p style="color: grey;"><i>Updated May 8, 2011, 9:44 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch adds an option in the 'Configure Rekonq...' dialog in the General tab to 'use the KDE wallet to store login information'. This is enabled by default, but now can be turned off, so that the 'store password for ...?' prompt does not appear.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Testing done. Works properly.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/rekonq.kcfg <span style="color: grey">(dba770b)</span></li>
<li>src/settings/settings_general.ui <span style="color: grey">(0b27dab)</span></li>
<li>src/webtab.cpp <span style="color: grey">(0994017)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/101317/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/101317/s/160/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2011/05/08/snapshot6_400x100.png" style="border: 1px black solid;" alt="The 'Configure Rekonq...' dialog" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>