[rekonq] Re: Review Request: Adds an option in configure dialog to disable the feature of saving password and login info in KDE wallet

[Andrea Diamantini]

> On May 10, 2011, 10:11 p.m., Andrea Diamantini wrote:
> > Let me say in general I hate our actual configuration dialog, that is increasing in an incredible way. I'd really like having a super simple one (with no more than 10 options).
> 
> Tirtha Chatterjee wrote:
>     someone told me that it is already possible to prevent storing of passwords by disconnecting Rekonq from KWallet. Is it so? In that case this patch would not be needed.

Not sure to understand this last. Can you please explain more precisely?


- Andrea


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101317/#review3252
-----------------------------------------------------------


On May 8, 2011, 9:44 p.m., Tirtha Chatterjee wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101317/
> -----------------------------------------------------------
> 
> (Updated May 8, 2011, 9:44 p.m.)
> 
> 
> Review request for rekonq.
> 
> 
> Summary
> -------
> 
> This patch adds an option in the 'Configure Rekonq...' dialog in the General tab to 'use the KDE wallet to store login information'. This is enabled by default, but now can be turned off, so that the 'store password for ...?' prompt does not appear.
> 
> 
> Diffs
> -----
> 
>   src/rekonq.kcfg dba770b 
>   src/settings/settings_general.ui 0b27dab 
>   src/webtab.cpp 0994017 
> 
> Diff: http://git.reviewboard.kde.org/r/101317/diff
> 
> 
> Testing
> -------
> 
> Testing done. Works properly.
> 
> 
> Screenshots
> -----------
> 
> The 'Configure Rekonq...' dialog
>   http://git.reviewboard.kde.org/r/101317/s/160/
> 
> 
> Thanks,
> 
> Tirtha
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/rekonq/attachments/20110511/e49dc821/attachment.htm