D21266: [WIP] Improve documentation of area classes

[David Hurka]

davidhurka marked 4 inline comments as done.
davidhurka added inline comments.

INLINE COMMENTS

> aacid wrote in area.h:108
> i don't know, you may want to ask Peter, but it was 6 years ago, i doubt he remembers.
> 
> What's your problem with it being static?

It would make sense to make it non static, because the first parameter is a NormalizedPoint (consists of x and y, xScale and yScale don’t scale the point).

Anyway, OKULARCORE_EXPORT is a reason to keep it static, right?

> aacid wrote in area.h:456
> What do you mean it's not used anywhere? Have you tried marking it as pure virtual?

pure virtual does not work becaues ObjectRect is instantiated.

I still don’t find it used anywhere.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D21266

To: davidhurka, #okular
Cc: aacid, okular-devel, joaonetto, tfella, ngraham, darcyshen
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20190602/44d1593d/attachment-0001.html>