D22617: Add view-pages-* icons, as needed in Okular for page layout selection

[David Hurka]

davidhurka added a comment.


  In D22617#500361 <https://phabricator.kde.org/D22617#500361>, @ndavis wrote:
  
  > In D22617#500346 <https://phabricator.kde.org/D22617#500346>, @davidhurka wrote:
  >
  > > - Why does the stylesheet need a background?
  >
  >
  > You only need to add the classes that you will use. If you want to use the window background color, you can use the Background class.
  
  
  Making the parts with background color transparent would be better, right? That would even work on systems which don’t access the stylesheet.
  
  >> - How are the color scheme properties in the stylesheet mapped to the reduced breeze palette in the HIG? (I think neutral or Beware Orange do not clearly map.)
  > 
  > Beware Orange is just the name of a color (it's an arbitrary name). NeutralText is a class that maps to the Neutral Text color in your system colorscheme. The color of Neutral Text just happens to be Beware Orange with the Breeze colorscheme, but you could make it purple by changing the colorscheme. Since Breeze uses Beware Orange, that color must be the default color in the stylesheet so that the icon color looks like Breeze in non-Qt apps.
  
  So this means, changing the Neutral Text property on your system will modify the Beware Orange parts of breeze icons, yes? That’s what I meant with mapping.
  
  I could imagine adding this to the HIG: A table with the reduced breeze color palette, the color names, the corresponding color scheme entries, and the existing description to the color. (So only add the color scheme entry.)
  
  > If you find any more flaws in the HIG, report an issue at https://invent.kde.org/websites/hig-kde-org/issues
  
  Concerning margins: https://invent.kde.org/websites/hig-kde-org/issues/12
  
  > or fork, patch and merge request to submit a patch for that repo.
  
  Not today, have to leave the wall plug now... :)

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D22617

To: davidhurka, #vdg, ndavis
Cc: #okular, kde-frameworks-devel, ngraham, LeGast00n, sbergeron, michaelh, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20190722/75cd0684/attachment.html>