On "gardening" code reviews

AnnoyingRains annoyingrain5 at gmail.com
Thu Feb 16 20:55:41 GMT 2023


Hey Luigi,

Thanks for the feedback! The stale MR closing has been a thing for a while,
just not particularly active, as I was waiting for my developer account
application to be approved so I could properly label MRs (which does help
with visibility!)

While I know this isn’t really a solution, the gardening team also has
“Love Projects”, which, at least historically, helps to renew interest in a
project. Possibly a Love Project could be opened for one of these projects
with many stale MRs, specifically mentioning them and the label that is
applied with them.

I know you said that you would prefer if this is opt in, but this service
is still opt out, like most KDE Gardening activities.

Either way, I do agree with your point, and will see if I can come up with
a solution.

Thanks
- Kye Potter, KDE Gardening

On Fri, 17 Feb 2023 at 2:52 am, Luigi Toscano <luigi.toscano at tiscali.it>
wrote:

> Hi,
>
> I see the the gardening started also on stale reviews.
> I think it should be opt-in, only for projects which request it.
> If that's the case already, please skip the rest (or read it anyway, it
> may be
> relevant if the policy changed).
>
> We have projects which are, let's say, sleepy, were reviews are not taken
> into
> account. You may say that, if some project is stale, it should go along its
> fate and be archive.
> I don't fully agree with that. As the KDE developer status allows access to
> each and every repository, a project may get some renewed interest at some
> point, and we have had several examples of this in the past.
>
> Now, I believe that automatically closing code contributions (which are
> slightly different beasts than bugs) can accelarate the process of making a
> project look obsolete, rather than helping them to be back. Having the
> reviews
> around may be a way for new contributors as start with a certain projects
> (by
> rechecking them and merging). It's true that the reviews are still there,
> just
> closed, but it's not the same in terms of visibility.
>
> Ciao
> --
> Luigi
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-gardening/attachments/20230217/7a64645a/attachment.htm>


More information about the Kde-gardening mailing list