D19007: Wait for DBus Reply Before Performing Computations

[David Narváez]

narvaez added inline comments.

INLINE COMMENTS

> bruns wrote in monitor.cpp:90
> The batchsize 40 by default, so currently the update interval is 200 files. 100 or 200 does not matter to much, it is just a crude limiter anyway.
> 
> A better fix would be emit the remaining time directly from the scheduler, which could adapt much better to fast and slow progress. And listening to signals on DBus is in general preferable to querying.

The batch size is **hardcoded** at 40 so querying it at at any interval is pointless, for that matter. Instead of hardcoding more magic numbers I would just #define BATCH_SIZE 40 inside the Engine lib and set the update interval to 5 * BATCH_SIZE.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D19007

To: narvaez, #baloo, bruns, astippich, poboiko
Cc: davidedmundson, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190215/d1bf2c03/attachment.html>