D19007: Wait for DBus Reply Before Performing Computations

Stefan BrĂ¼ns noreply at phabricator.kde.org
Fri Feb 15 15:03:23 GMT 2019


bruns added inline comments.

INLINE COMMENTS

> narvaez wrote in monitor.cpp:90
> The batch size is **hardcoded** at 40 so querying it at at any interval is pointless, for that matter. Instead of hardcoding more magic numbers I would just #define BATCH_SIZE 40 inside the Engine lib and set the update interval to 5 * BATCH_SIZE.

Actually, both values are completely unrelated. They exist for similar reasons (commiting each file / updating the time for each file hurts performance). Just hardcoding e.g. 100 here would do.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D19007

To: narvaez, #baloo, bruns, astippich, poboiko
Cc: davidedmundson, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190215/19c03f5d/attachment.html>


More information about the Kde-frameworks-devel mailing list