D19007: Wait for DBus Reply Before Performing Computations

[Stefan Brüns]

bruns added inline comments.

INLINE COMMENTS

> narvaez wrote in monitor.cpp:90
> It does fix the issue because if getBatchSize returns 0 then updateInterval is set to 100. It does introduce another issue which is that it won't allow for an update interval under 100 (say, if the batch size was configurable in the future which is something you should really consider) but that is a minor issue compared to the crash this fixes.

The batchsize 40 by default, so currently the update interval is 200 files. 100 or 200 does not matter to much, it is just a crude limiter anyway.

A better fix would be emit the remaining time directly from the scheduler, which could adapt much better to fast and slow progress. And listening to signals on DBus is in general preferable to querying.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D19007

To: narvaez, #baloo, bruns, astippich, poboiko
Cc: davidedmundson, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190215/0c92c468/attachment-0001.html>