D19007: Wait for DBus Reply Before Performing Computations

[David Narváez]

narvaez added inline comments.

INLINE COMMENTS

> davidedmundson wrote in monitor.cpp:90
> That won't fix the issue.
> 
> getBatchSize is still returning a QDBusPendingReply, using the value before it's loaded will always be zero.

It does fix the issue because if getBatchSize returns 0 then updateInterval is set to 100. It does introduce another issue which is that it won't allow for an update interval under 100 (say, if the batch size was configurable in the future which is something you should really consider) but that is a minor issue compared to the crash this fixes.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D19007

To: narvaez, #baloo, bruns, astippich, poboiko
Cc: davidedmundson, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190215/a4f6ca10/attachment.html>