[WebKit-devel] Review Request: KWebKitPart - Fix Windows build

[Dawit Alemayehu]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105002/#review14008
-----------------------------------------------------------



src/sslinfodialog_p.h
<http://git.reviewboard.kde.org/r/105002/#comment11104>

    You can simply remove the KDE_EXPORT. I should have really removed that before adding that header file. It is a private header file after all and is only there to make it possible to compile the code.


- Dawit Alemayehu


On May 20, 2012, 10:07 p.m., Andrius da Costa Ribas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105002/
> -----------------------------------------------------------
> 
> (Updated May 20, 2012, 10:07 p.m.)
> 
> 
> Review request for kdewin, kwebkitpart and Maks Orlovich.
> 
> 
> Description
> -------
> 
> 2 small points to fix Windows build of KWebKitPart.
> 
> 1- We're always KDE_IMPORTing the KSslInfoDialog - symbol export/importing problems are often not detected on linux.
> 2- ifdef'd a X11 header (but probably it isn't needed at all).
> 
> 
> Diffs
> -----
> 
>   src/settings/webkit_filter.cpp 2fc48da 
>   src/sslinfodialog_p.h de061e5 
> 
> Diff: http://git.reviewboard.kde.org/r/105002/diff/
> 
> 
> Testing
> -------
> 
> Tested using MSVC 2010 on a Win7 64bit machine. Works pretty fine on Konqueror :)
> 
> 
> Thanks,
> 
> Andrius da Costa Ribas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/webkit-devel/attachments/20120521/b80dcc68/attachment.html>