[WebKit-devel] Review Request: KWebKitPart - Fix Windows build

[Andrius da Costa Ribas]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105002/
-----------------------------------------------------------

Review request for kdewin, kwebkitpart and Maks Orlovich.


Summary (updated)
-----------------

KWebKitPart - Fix Windows build


Description (updated)
-------

2 small points to fix Windows build of KWebKitPart.

1- We're always KDE_IMPORTing the KSslInfoDialog - symbol export/importing problems are often not detected on linux.
2- ifdef'd a X11 header (but probably it isn't needed at all).


Diffs
-----

  src/settings/webkit_filter.cpp 2fc48da 
  src/sslinfodialog_p.h de061e5 

Diff: http://git.reviewboard.kde.org/r/105002/diff/


Testing (updated)
-------

Tested using MSVC 2010 on a Win7 64bit machine. Works pretty fine on Konqueror :)


Thanks,

Andrius da Costa Ribas

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/webkit-devel/attachments/20120520/37d5baf7/attachment.html>