[WebKit-devel] [Bug 261223] Download name of link targets containing special characters get ignored

[Dawit Alemayehu]

https://bugs.kde.org/show_bug.cgi?id=261223





--- Comment #20 from Dawit Alemayehu <adawit kde org>  2011-03-06 20:56:40 ---
(In reply to comment #19)
> > > Agreed. But I find the isPrint() conversion doubtful. Please also make
> > > sure all existing testcases work properly.
> > 
> > Why do you think the isPrint() conversion is doubtful ? It correctly
> > excludes every control character, which includes the vertical and
> > horizontal spacers (\v, \t, \n, \r), while making it possible to allow
> > unicode characters present in the string.
> > 
> > On top of that all the test cases pass as well...
> 
> Hm, that change seems to be one of the central points of this change, no? ;) 
> Ok, ignore me then. I'll review that one tomorrow again when I'm less 
> confused.

Yes, the use of isPrint() is esentially the fix and the unit test for it shows
no problems:

$ ./httpheaderdispositiontest
********* Start testing of HeaderDispositionTest *********
Config: Using QTest library 4.7.2, Qt 4.7.2
PASS   : HeaderDispositionTest::initTestCase()
PASS   : HeaderDispositionTest::runAllTests()
PASS   : HeaderDispositionTest::cleanupTestCase()
Totals: 3 passed, 0 failed, 0 skipped
********* Finished testing of HeaderDispositionTest *********

So in it goes. :)

-- 
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.