[WebKit-devel] KDE WebKit status update [Remix]

[Dawit A.]

On Sunday 18 October 2009 12:57:28 Urs Wolfer wrote:
> On Sunday 18 October 2009 17:02:25 Dawit A. wrote:
> > On Saturday 17 October 2009 15:02:46 Urs Wolfer wrote:
> > > On Thursday 15 October 2009 20:29:17 Dawit A. wrote:
> > > > On Thursday 15 October 2009 11:36:26 Michael Howell wrote:
> > >
> > > [..]
> > >
> > > > > class AccessManager {
> > > > > ...
> > > > > };
> > > > > namespace NetworkIntegration {
> > > > > typedef KIO::AccessManager AccessManager;
> > > > > ...
> > > > > }
> > > >
> > > > That is exactly what I did... I guess I will create a reviewboard
> > > > request to get this included for 4.3.3 since the patch is trivial
> > > > enough addition, but of a great deal help to cleaning up kdewebkit
> > > > and making it ready for kdereview.
> > >
> > > Why have you put everything into one file? I prefer one public class
> > > per file. Otherwise I agree with your patch.
> >
> > Because the two classes are related enough to one another and as such
> >  grouping them into one file seemed logical. It also reduces the number
> > of header files one has to include to do KIO integration and we do not
> > have to worry about what name to use for the file as we did with the
> > class. I also thought that doing it this way would make it easier to have
> > this change included into the next 4.3 release. Anyhow, to me creating
> > separate files for such trivial classes does not seem necessary, but I
> > have no preference about this one way or the other...
> 
> Okay. This is probably a point which can be discussed with the review for
> kdelibs.

This is already up for review as there is no reason for it to depend on 
kdewebkit being in kdereview. In fact the dependency should be the other way 
around, sort of... Anyhow, I already posted it to kdereview:

http://reviewboard.kde.org/r/1711/

> > BTW, we need to prevent knetworkcookiejar.h from being installed in
> >  kdewebkit since it is going to be moved to KIO. It needs to be an
> > internal class until then...
> 
> Okay for me. As soon as it is in kdelibs, it can be dropped.
> 
> When do you think should we move kdewebkit into kdereview? IMHO it can be
>  done soon.

Well I have no object to that now that I went ahead and made the cookiejar 
implementation internal until it can be moved to the proper location. The only 
question is by "move" do you mean "copy" to kdereview until its approval into 
kdelibs ? Otherwise, that would mean one has to compile stuff from both 
kdereview and playground to get webkitpart to work, no ? In other words how 
should the transition going to be handled ?