[Breeze] [Bug 418996] Dark Telegram icon on dark Breeze theme

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=418996

Nate Graham <nate at kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|CONFIRMED                   |RESOLVED
      Latest Commit|https://cgit.kde.org/breeze |https://invent.kde.org/plas
                   |-icons.git/commit/?id=309ea |ma/plasma-workspace/commit/
                   |93012f3fe990625419bcca9c119 |7363d0e0f3c1a447e6264e92762
                   |15ebc8ad                    |735bd33da2682
         Resolution|---                         |FIXED

--- Comment #26 from Nate Graham <nate at kde.org> ---
Git commit 7363d0e0f3c1a447e6264e92762735bd33da2682 by Nate Graham, on behalf
of Vlad Zahorodnii.
Committed on 05/05/2022 at 17:30.
Pushed by ngraham into branch 'master'.

applets/systemtray: Prefer IconName over IconPixmap

In case both IconName and IconPixmap are provided, the system tray
applet is going to prefer the pixmap.

That can create a dark icon on dark background bug because plasma can't
recolor pixmaps.

The SNI spec recommends visualizations to prefer icons over pixmaps:

> An icon can either be identified by its Freedesktop-compliant icon
> name, carried by this property of by the icon data itself, carried by
> the property IconPixmap. Visualizations are encouraged to prefer icon
> names over icon pixmaps if both are available (FIXME: still not very
> defined: could e the pixmap used as fallback if an icon name is not found?)

M  +40   -36   applets/systemtray/statusnotifieritemsource.cpp

https://invent.kde.org/plasma/plasma-workspace/commit/7363d0e0f3c1a447e6264e92762735bd33da2682

-- 
You are receiving this mail because:
You are the assignee for the bug.