[systemsettings] [Bug 403557] UTF-8 characters are not saved correctly using the implicit path configuration module

[Jos van den Oever]

https://bugs.kde.org/show_bug.cgi?id=403557

Jos van den Oever <jos at vandenoever.info> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|CONFIRMED                   |RESOLVED
      Latest Commit|                            |https://commits.kde.org/kco
                   |                            |nfig/2cdcd4f30666fd1095ab7c
                   |                            |f31361e404db871075
   Version Fixed In|                            |5.56
         Resolution|---                         |FIXED

--- Comment #16 from Jos van den Oever <jos at vandenoever.info> ---
Git commit 2cdcd4f30666fd1095ab7cf31361e404db871075 by Jos van den Oever.
Committed on 20/02/2019 at 16:19.
Pushed by vandenoever into branch 'master'.

Write valid UTF8 characters without escaping.

Summary:
commit 6a18528 introduced escaping of bytes >= 127 to ensure that
KConfig files are valid UTF8.
The simplistic approach with a cutoff results in many escaped bytes
where it is not required. Especially non-western configuration files
would have many escapes.

This commit fixes that by only escaping bytes that are not valid UTF8.
FIXED-IN: 5.56

Test Plan: ninja && ninja test

Reviewers: dfaure, arichardson, apol, #frameworks, thiago

Subscribers: rapiteanu, kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D19107

M  +52   -2    autotests/kconfigtest.cpp
M  +2    -0    autotests/kconfigtest.h
M  +113  -9    src/core/kconfigini.cpp

https://commits.kde.org/kconfig/2cdcd4f30666fd1095ab7cf31361e404db871075

-- 
You are receiving this mail because:
You are the assignee for the bug.