XMI_FILE_VERSION in umbrello/version.h

[Oliver Kellogg]

On Mon, Sep 28, 2020 at 10:14 AM Ralf Habacker <ralf.habacker at freenet.de> wrote:
> > [...]
> > #if defined(ENABLE_WIDGET_SHOW_DOC) || defined(ENABLE_XMIRESOLUTION)
> > #define XMI_FILE_VERSION "1.6.19"
> > #else
> > #define XMI_FILE_VERSION "1.6.18"
> > #endif
>
> You need to increment each number.

If I do that then we will have 1.6.19 in the #else case -
which redefines the meaning of that number because right now, 1.6.19
is in the #if case.

> [...]
> > Is it okay to do this work on the master branch?
>
> I assume that related patches will affect the ui, which limits changes
> to the master branch.
>
> I suggest to apply changes into a feature branch e.g.
> work/73847-tagged-uml or to a branch of your private fork [...]

Your first suggestion sounds good to me, I'll make a feature branch.

> If you want to have a review of your changes I suggest to open a merge
> request either from the mentioned work branch or from a branch of your
> private repo.

Thanks,

Oliver