XMI_FILE_VERSION in umbrello/version.h

[Ralf Habacker]

Am 27.09.20 um 17:38 schrieb Oliver Kellogg:
> Hi,
> 
> While working on https://bugs.kde.org/show_bug.cgi?id=73847
> I see the following in umbrello/version.h :
> 
> #if defined(ENABLE_WIDGET_SHOW_DOC) || defined(ENABLE_XMIRESOLUTION)
> #define XMI_FILE_VERSION "1.6.19"
> #else
> #define XMI_FILE_VERSION "1.6.18"
> #endif

You need to increment each number.

 > #if defined(ENABLE_WIDGET_SHOW_DOC) || defined(ENABLE_XMIRESOLUTION)
 > #define XMI_FILE_VERSION "1.6.20"
 > #else
 > #define XMI_FILE_VERSION "1.6.19"
 > #endif
 >

Each of the mentioned feature changes the xmi file structure, but are 
only enabled on minor versions >= 70 (unstable release) because they 
need more testing to be enabled in stable versions.

> 
> I'm not sure how to update the XMI_FILE_VERSION for the added elements
> <UML:ModelElement.taggedValues>
>      <UML:TaggedValue>
> proposed in bug 73847 comment 21 (as well as the <UML:Attribute>s
> optionally nested in <UML:Stereotype> proposed in comment 20).
> 
> Is it okay to do this work on the master branch?

I assume that related patches will affect the ui, which limits changes 
to the master branch.

I suggest to apply changes into a feature branch e.g. 
work/73847-tagged-uml or to a branch of your private fork of the 
umbrello project (https://invent.kde.org/okellogg/umbrello), which can 
be merged after the implementation is finished.

Branches from a work branch can be merged directly, while branches on 
your private fork can only be merged by a gitlab merge request.

If you want to have a review of your changes I suggest to open a merge 
request either from the mentioned work branch or from a branch of your 
private repo.

You can prefix it with WIP: in the title to indicate a "work in process" 
until the implementation is finished.

Regards
Ralf