[umbrello] [Bug 430322] Crash on exit with tabbed diagrams enabled

[Oliver Kellogg]

https://bugs.kde.org/show_bug.cgi?id=430322

--- Comment #2 from Oliver Kellogg <okellogg at users.sourceforge.net> ---
Git commit bd8b3b1c9f2ccbd54b7fb34d95db8e6d8d94df0b by Oliver Kellogg.
Committed on 13/12/2020 at 16:30.
Pushed by okellogg into branch 'master'.

Followup to commit 9d9800c fix for crash on exit with tabbed diagrams

There was a further crash on closing in the code path
  UMLApp::slotFileClose() => slotFileNew() => m_doc->newDocument()
due to DiagramsModel::m_views not having been reset to empty.
This caused access to stale UMLView objects already deconstructed.

umbrello/models/diagramsmodel.{h,cpp}
- New function removeAllDiagrams clears content of m_views.

umbrello/uml.cpp
- In function slotFileClose call diagramsModel()->removeAllDiagrams()
  on m_doc before calling slotFileNew().

M  +10   -0    umbrello/models/diagramsmodel.cpp
M  +1    -0    umbrello/models/diagramsmodel.h
M  +2    -0    umbrello/uml.cpp

https://invent.kde.org/sdk/umbrello/commit/bd8b3b1c9f2ccbd54b7fb34d95db8e6d8d94df0b

-- 
You are receiving this mail because:
You are the assignee for the bug.