[umbrello-devel] [umbrello] [Bug 338797] SEGV crash when umbrello is opening AIXM files

[Ralf Habacker]

https://bugs.kde.org/show_bug.cgi?id=338797

--- Comment #11 from Ralf Habacker <ralf.habacker at freenet.de> ---
(In reply to Oliver Kellogg from comment #10)
> (In reply to Ralf Habacker from comment #8)
> > (In reply to Oliver Kellogg from comment #7)
> > > 
> > > Since the recent class-or-package modifications, m_umlObject may also point
> > > to UMLPackage - which means that the static_cast to UMLClassifier* is
> > > invalid.
> > 
> > class-or-package uml objects are created of type UMLClassifier. A later
> > retype to a package only sets the WidgetBase class base type member to
> > UMLPackage, the object itself is still an UMLClassifier. A cast to
> > UMLClassifier therefore should not fail. See CppTree2Uml::parseNamespace for
> > more details. 
> 
> Ah, I forgot to do a refresh before committing and did not see your comment,
> sorry.
> 
> Are you saying that the new constructor,
>   ClassifierWidget(UMLScene * scene, UMLPackage *o)
> is only ever called with UMLClassifier* as the second argument?
yes, the constructor was added at an early state of the class-or-package
support, when I initial tried to retype to a real uml package object,  but
stopped this approach because of too many issues. I should have removed it
before merging the branch into master
> I guess I was barking up the wrong tree then.
May be not: What is left over to handle UmlPackage with ClassifierWidget
complete ? 
Then PackageWidget could be dropped and umbrello could have a feature to retype
any Package to a Classifier and vice versa on the fly.

-- 
You are receiving this mail because:
You are the assignee for the bug.