[Uml-devel] [Bug 67059] Automatic layout of diagrams

[Ralf Habacker]

https://bugs.kde.org/show_bug.cgi?id=67059

--- Comment #21 from Ralf Habacker <ralf.habacker at gmail.com> ---
(In reply to comment #20)
> Created attachment 69331 [details]
> patch fixes a few typos in layoutgenerator.h
> 
> (In reply to comment #16)
> > Created attachment 69318 [details]
> > diagram auto layout for class diagrams
> > 
> > This is my first version of a diagram auto layout implementation. Please
> > review
> 
> Super, thanks for doing this.
> Just some superficial observations:
> - layoutgenerator.h should not have execute rights.
thanks, will fix
> - layoutgenerator.h seems to contain the full implementation
>   how about shifting the bodies to a new file layoutgenerator.cpp ?
     will do so, when the api has been stabilised -  having header only classes
in early design state makes refactoring easier, which will happens more than
one time. 

For example: Major part of his patch (the dot file creating) could also be used
as dot diagram exporter, so I'm currently thinking about a move of the related
part to a class DotGenerator.

-- 
You are receiving this mail because:
You are the assignee for the bug.