[Uml-devel] [Bug 67059] Automatic layout of diagrams

Oliver Kellogg okellogg at users.sourceforge.net
Tue Mar 6 18:46:10 UTC 2012


https://bugs.kde.org/show_bug.cgi?id=67059

--- Comment #20 from Oliver Kellogg <okellogg at users.sourceforge.net> ---
Created attachment 69331
  --> https://bugs.kde.org/attachment.cgi?id=69331&action=edit
patch fixes a few typos in layoutgenerator.h

(In reply to comment #16)
> Created attachment 69318 [details]
> diagram auto layout for class diagrams
> 
> This is my first version of a diagram auto layout implementation. Please
> review

Super, thanks for doing this.
Just some superficial observations:
- layoutgenerator.h should not have execute rights.
- layoutgenerator.h seems to contain the full implementation;
  how about shifting the bodies to a new file layoutgenerator.cpp ?

-- 
You are receiving this mail because:
You are the assignee for the bug.




More information about the umbrello-devel mailing list