[Uml-devel] enhanced version to draw note widget on TOP

[Achim Spangler]

Hi,
the old UMLWidget::setSelected() function overwrote on each DEselection of a 
widget the previous Z setting of the widget, so that a note widget instance 
lost its TOP condition, as soon as it was selected->de-selected first.

I changed the deselection resetting of Z to use the m_origZ - this attribute 
has been used in an older version of this function. The use of this member 
variable got lost during that change.

Thus - the note widget is now always drawn on TOP of all widgets.

Bye,
Achim
Am Montag, 27. November 2006 12:11 schrieb Achim Spangler:
> Hi,
> here are two diffs which:
> a) fix a crash on closing of a document, which is triggered by
>    destructor ToolBarStateArrow::~ToolBarStateArrow(){}
>    --> the call of m_selectionRect.clear();
>        triggered an abort
>    --> I simply comment this out, as we can rely on the
>        automatic destruction of direct element variables
>    --> we shouldn't explicitly call clear() when this is
>        not needed, and causes a segfault for some configurations
>
> b) change notewidget to use setZ(10) so that the notes are drawn on
>    top of all other widgets.
>    The bodies of synchronous messages in sequence diagrams were always
>    drawn on top of my notes in my diagrams - which is really not the
>    wanted behaviour
>
> I separated the small diffs (each just one line), so that they can be
> applied separatedly.
>
> Bye,
> Achim
-------------- next part --------------
A non-text attachment was scrubbed...
Name: DrawNoteOnTop.diff
Type: text/x-diff
Size: 1602 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/umbrello-devel/attachments/20061127/227216c8/attachment.bin>