[Uml-devel] Suggestion: Use temp file also for local save

[Sebastian Stein]

Achim Spangler <Achim.Spangler at mnet-online.de> [040713 12:36]:
> umbrello uses at the moment a direct save into the target file, if the file is 
> _not_ on network.

That seems to be a good idea. The only problem is, that you have to copy the
temp file to the local file at the end. This might slow things down.
Nevertheless, I think it is a good idea and applied the patch.

I have question about the patch. You write:


+    #if 0
                // now check if we are writing to a local file
                if ( url.isLocalFile() )
                {
@@ -544,7 +549,16 @@ bool UMLDoc::saveDocument(const KURL& ur
                } else {
                        file.setName( tmpfile.name() );
                }
-
+    #else
+    // save in _any_ case to a temp file
+

Why #if 0? If you think your code is correct, we should remove the old code.
If we need the old code back, we could go back in CVS. I removed the
commented out code.

Thanks for your work!

Sebastian 
-- 
http://www.hpfsc.de/ - die Seite rund um:
Assembler, Bundeswehr, TFT LCDs, Halle/Saale, Fahrradtouren, Neuseeland,
Wanderstaat Mauma, Raumschiff USS Nathan, Enemy Room, MLCAD Tutorial