[Uml-devel] Re: problem with font property setting

[Achim Spangler]

Hi,
well - I fixed the problem myself.

Please check and apply the patch.

What does it:
1) umbrello/umlwidget.cpp
1.1) constructors take the optionState.uiState.font
       corresponding to the settings for fillColor, lineColor, lineWidth
1.2) UMLWidget::init() takes the optionState.uiState.font also
       corresponding to fillColor, lineColor, lineWidth
==>> if there is _no_ font setting in the XMI file, the default
         value from optionState is used ( important for load )

2) umbrello/dialogs/settingsdlg.cpp
    Set the current optionState.uiState.font as initial value for the dialog
    window with
    m_FontWidgets.chooser->setFont( m_pOptionState->uiState.font );
==>> the user isn't irritated by the fact, that the last default font change
         isn't displayed as initial value on next call of this dialog
  (( now the font selector syncs the spin button font size with the
      size-list ; but as least for my kdelibs4 version, the highlighted entry
      in list is not changed on a font size change via the spin-button - but
      this is more a kdelibs problem, IMHO ))

Maybe we sould change the font handling corresponding to the line and color 
handling - means: if user doesn't change font specific to a diagram, then the
font shouldn't be stored per diagram.

Example:
If due to some X11 or printer changes another font is rendered better on 
screen and/or printer, a global change via the default setting dialog would 
be nice.
My personal solution was to clear all font settings from XMI file, and then 
open it again with my attached changes -> the default font is applied to each 
diagram.
( in my case the switch to debian caused a bad dispay of the "Sans" font at 
font size of 10 - which was the font setting during the creation of all 
previous diagrams -> I needed to change to another better displayed font )


######
Another issue - hello Oliver!
---------------------------------

Probably due to some last changes, my old warning/debug messages on the call 
of UMLWidget::adjustAssocs() are very active during load of a XMI file.
As far as I can remember, they weren't printed before the last ( some days ) 
CVS changes.


Bye,
Achim

Am Mittwoch, 7. Juli 2004 17:46 schrieben Sie:
> Hi,
> the current CVS seems to have some problems with the font property dialog
> and general handling ( the global UI font settings - not the diagram
> specific ).
>
> a) in the dialog the list entries and the spin up/down buttons for the size
>     are _not_ in sync ( slection one item in list doesn't cause the
> spinbutton view to sync )
>
> b) if I leave the dialog with OK, and restart the dialog, the new settings
>     are _not_ used any more
>
> c) the font setting of the file .kde/share/config/umbrellorc is _not_ used
>     ( I changed it manually )
>
>
> I'm not shure if this depends on my lastly change to Knoppix/Debian.
> I updated the kdelibs4 to 3.2.3 ( unstable series ) and the Qt3 to 3.3 (
> was forced by the central .configure of kdesdk ).
> --> Maybe the problem is caused by some library incompatibilities
>  ( I didn't update the kdebase and other packages to 3.2.3, as
>    I had several bad problems with them - taskbar freezed and
>    focus to text input fields didn't work _sometimes_ - both
>    problems occured after some unpredictable time )
> ( I performed make clean ; make -f Makefile.cvs; ./configure
>   -> there should be no old parts of my previous Mandrake
>       install in teh workingcopy )
>
> So - can somebody else please check, if current CVS has still correct font
> selection handling.
> Or can somebody give me some hints on selecting KDE packages to get a
> workinbg Debian install ( where I can compiler currenct kdesdk CVS ).
>
>
> Bye,
> Achim
-------------- next part --------------
A non-text attachment was scrubbed...
Name: FixFontHandling.diff
Type: text/x-diff
Size: 2625 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/umbrello-devel/attachments/20040708/82960712/attachment.bin>